feat(javareach): Various improvements #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Map classes in BOOT-INF/classes to the root application, so that we can apply our `AssumeAllClassesReachable` strategy for dealing with dependency injection. - Handle META-INF/versions/ directories when building our class -> artifact map.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1663 +/- ##
==========================================
- Coverage 64.56% 64.54% -0.02%
==========================================
Files 155 155
Lines 15997 15997
==========================================
- Hits 10329 10326 -3
- Misses 4984 4986 +2
- Partials 684 685 +1 ☔ View full report in Codecov by Sentry. |
oliverchang
changed the title
cuixq
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better handle Spring Boot applications by mapping classes in BOOT-INF/classes to the root application, so that we can apply our
AssumeAllClassesReachablestrategy for dealing with dependency injection.Handle service providers in META-INF/services/
Handle META-INF/versions/ directories when building our class -> artifact map.
Fix some bugs in our class finding by properly handling inner classes and generics.
Add a log line printing out some final metrics on reachability.