feat: add durable support for overriding the bucket #2462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a more durable solution to the edge case we were trying to correct from, where the Bug in Datastore was from a GIT source (with a different path to the source file) than what we wanted to trigger reimporting for, and so various sanity checks and assumptions fail. This adds support for overriding the bucket name (and optionally, the path within the bucket), which is normally self-determined from the existing record. ``` pipenv run python tools/datafix/reimport_gcs_record.py --verbose --no-dry-run --project oss-vdb --bucket cve-osv-conversion:osv-output CVE-2022-2816 ```
|
This is instead of the quick hacks in 536d840 |
another-rex
reviewed
Aug 12, 2024
Adds an example to describe the more complex way of overriding the bucket.
andrewpollock
changed the title
another-rex
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a more durable solution to the edge case we were trying to correct from, where the Bug in Datastore was from a GIT source (with a different path to the source file) than what we wanted to trigger reimporting for, and so various sanity checks and assumptions fail.
This adds support for overriding the bucket name (and optionally, the path within the bucket), which is normally self-determined from the existing record.