fix(nvd-mirror): use a more efficient technique to split NVD by year #2517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To address apparent overrun issues (and also hopefully reduce the amount of RAM the job requires) use a more time and memory efficient technique to split the monolithic NVD dump by year. This avoids creating multiple in-memory arrays of the same data Refactor invocation for better readability
michaelkedar
approved these changes
Aug 23, 2024
I've manually built a container and hacked up a Kubernetes job YAML to run it in Staging currently and it is flying along using < 1% of the RAM allocated, by the looks of things :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address apparent overrun issues (and also hopefully reduce the amount of RAM the job requires) use a more time and memory efficient technique to split the monolithic NVD dump by year.
This avoids creating multiple in-memory arrays of the same data
Refactor invocation for better readability