-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tools): add API performance test tool #2518
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really cool!
To enhance the readability and maintainability of this, could you please:
- Expand the docstrings to include arguments and returns per https://google.github.io/styleguide/pyguide.html#s3.8.3-functions-and-methods
- Add type hints per https://google.github.io/styleguide/pyguide.html#s2.21-type-annotated-code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good!
It would be good to add a script to generate the JSON file as well, and at least add a sample JSON file with a few entries so users know how to generate their own JSON file to test with.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to add the function argument types, and it should be good to merge!
Could be useful to store the results to use to verify behavior changes, but that can be a follow up later.
API perf test script: