feat: add a cron job to test OSV API on test instance #2540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hogo6002
commented
Aug 30, 2024
deployment/clouddeploy/gke-workers/environments/oss-vdb-test/staging-test.yaml
Outdated
Show resolved
Hide resolved
hogo6002
requested review from
andrewpollock,
michaelkedar,
another-rex and
cuixq
another-rex
reviewed
Sep 2, 2024
There was a problem hiding this comment.
I wonder if we can use the script directly to avoid duplicating it, but maybe copying is just simpler and if we make changes to the script we don't need to worry about breaking staging_test.
There was a problem hiding this comment.
It's probably possible, you'd just have to build the Docker image from the root of the repo to be able to copy the files over.
There was a problem hiding this comment.
My idea is to remove the script from tools/, if we want to test this locally we can just use the docker/staging_api_test/run.sh.
michaelkedar
reviewed
Sep 3, 2024
There was a problem hiding this comment.
It's probably possible, you'd just have to build the Docker image from the root of the repo to be able to copy the files over.
deployment/clouddeploy/gke-workers/environments/oss-vdb-test/staging-test.yaml
Outdated
Show resolved
Hide resolved
another-rex
approved these changes
Sep 9, 2024
michaelkedar
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our test instance lacks real-life traffic, making it difficult to catch API query errors.
Converting tools/api-performance-test into a cron job that runs for one hour daily. This job will send traffic to the test instance's API, helping us identify errors before deploying changes to production.
The tools/api-performance-test script will be deleted once the cron job is running stably.