feat(source-sync): overhaul behaviour #2866
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit: - Adds support to download all sources concurrently, each in their own thread, rather than sequentially, in the interests of saving time. It emits an interim progress report of which sources are still being downloaded every time a thread completes - Adds support for an arbitrary number of sources to download other than just all or one of them - Adds support for excluding an arbitrary number of sources when downloading all of them - fixes a bug where the `--verbose` flag was not being honoured when downloading all sources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit:
Adds support to download all sources concurrently, each in their own thread, rather than sequentially, in the interests of saving time. It emits an interim progress report of which sources are still being downloaded every time a thread completes
Adds support for an arbitrary number of sources to download other than just all or one of them
Adds support for excluding an arbitrary number of sources when downloading all of them
fixes a bug where the
--verboseflag was not being honoured when downloading all sources.