-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 3.0.1+1 #689
Version 3.0.1+1 #689
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version adds a minor documentation change. With non-null by default implemented as of Dart 2.12, developers should avoid adding more uses of the Optional type in there code, and ideally start migrating existing uses to nullable types. Not marking this as deprecated yet, since not all users have migrated their codebases to NNBD, and migration off this type has some tricky edge-cases.
361ebe4
to
34cc6a9
Compare
@@ -1,3 +1,9 @@ | |||
#### 3.0.1+1 - 2021-10-14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI 3.0.2
would have been more idiomatic.
https://github.com/dart-lang/sdk/wiki/External-Package-Maintenance#bumping-versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh weird. TIL!
Out of curiosity, when did this rule change? We'd been doing this for years for "no functional effect" changes like documentation, as had other packages like vm_service, dart_style, async, etc. Might be worth sending out a note to the dart/flutter teams.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a bunch of confusion years ago about the intended patterns. Some packages only used +1
version changes for 0.x
releases, while other packages kept using them after the 1.x
release for doc changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM - glad we've got a clearly documented policy now!
This version adds a minor documentation change.
With non-null by default implemented as of Dart 2.12, developers should
avoid adding more uses of the Optional type in there code, and ideally
start migrating existing uses to nullable types.
Not marking this as deprecated yet, since not all users have migrated
their codebases to NNBD, and migration off this type has some tricky
edge-cases.
Related: #679
Related: #672 (deprecate optional)