Unum part 3 #146
Merged
Unum part 3 #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using uformattable::UFormattable provides generalized value parsing for the particular locale. While this isn't the full spectrum of the underlying functions that ICU4C provides for value parsing, it's general enough to be usable for all the use cases where parsing is needed, *if* needed. However, those uses are rare. Issue google#141.
kpozin
approved these changes
Jul 9, 2020
|
|
||
| /// Implements `unum_parseToUFormattable`. Since 0.3.1. | ||
| /// | ||
| /// > **WARNING** the `parse_position` parameter is with respect to the number index |
There was a problem hiding this comment.
"with respect to the number index" is a bit unclear. Maybe something like the "starting index of the numeric string"?
| &self, | ||
| fmt: &uformattable::UFormattable<'a>, | ||
| ) -> Result<ustring::UChar, common::Error> { | ||
| const CAPACITY: usize = 200; |
There was a problem hiding this comment.
Is this capacity recommended somewhere in ICU4C documentation? Consider mentioning the source in a comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 3 in the unum number formatting support work.
Please see individual commits for details of the change.
Adds support for UFormattable.
Using uformattable::UFormattable provides
generalized value parsing for the particular
locale.
While this isn't the full spectrum of the
underlying functions that ICU4C provides
for value parsing, it's general enough
to be usable for all the use cases where
parsing is needed, if needed. However,
those uses are rare.
Issue #141.