Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define a trait for Intl.RelativeTimeFormat #183

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Define a trait for Intl.RelativeTimeFormat #183

merged 1 commit into from
Nov 18, 2020

Conversation

filmil
Copy link
Member

@filmil filmil commented Nov 4, 2020 •
edited
Loading

No description provided.

@filmil filmil self-assigned this Nov 4, 2020
@filmil filmil requested a review from kpozin November 4, 2020 01:07
@google-cla google-cla bot added the cla: yes CLA signed label Nov 4, 2020
@filmil
Copy link
Member Author

filmil commented Nov 4, 2020

@zbraniecki PTAL?

@filmil filmil force-pushed the ecma402-relative-time-format branch from a97f599 to af95a3d Compare November 4, 2020 01:19
@kpozin
Copy link
Contributor

kpozin commented Nov 9, 2020

Title nit: Maybe "Define a trait" instead of "Implement a trait"? When I see "Implement a trait," I think impl FooTrait for Bar.

zbraniecki
zbraniecki approved these changes Nov 9, 2020
View reviewed changes
ecma402_traits/src/lib.rs Outdated Show resolved Hide resolved
ecma402_traits/src/relativetimeformat.rs Outdated Show resolved Hide resolved
@filmil filmil changed the title Implement a trait for Intl.RelativeTimeFormat Define a trait for Intl.RelativeTimeFormat Nov 18, 2020
@filmil filmil force-pushed the ecma402-relative-time-format branch from af95a3d to d77f1c7 Compare November 18, 2020 19:21
@filmil
Copy link
Member Author

filmil commented Nov 18, 2020

Title nit: Maybe "Define a trait" instead of "Implement a trait"? When I see "Implement a trait," I think impl FooTrait for Bar.

Done

@filmil filmil merged commit 7914397 into google:master Nov 18, 2020
@filmil filmil deleted the ecma402-relative-time-format branch September 17, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbraniecki zbraniecki zbraniecki approved these changes

@kpozin kpozin kpozin approved these changes

Assignees

@filmil filmil

Labels
cla: yes CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filmil @kpozin @zbraniecki