Bug/10040 input copy #10183

zutigrm · 2025-02-06T09:18:29Z

Summary

Addresses issue:

Input questionnaire copy not the same as Figma designs #10040

Relevant technical choices

PR Author Checklist

My code is tested and passes existing unit tests.
My code has an appropriate set of unit tests which all pass.
My code is backward-compatible with WordPress 5.2 and PHP 7.4.
My code follows the WordPress coding standards.
My code has proper inline documentation.
I have added a QA Brief on the issue linked above.
I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

Run the code.
Ensure the acceptance criteria are satisfied.
Reassess the implementation with the IB.
Ensure no unrelated changes are included.
Ensure CI checks pass.
Check Storybook where applicable.
Ensure there is a QA Brief.
Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

Ensure the PR has the correct target branch.
Double-check that the PR is okay to be merged.
Ensure the corresponding issue has a ZenHub release assigned.
Add a changelog message to the issue.

github-actions · 2025-02-06T09:25:13Z

Build files for 0bb61a1 have been deleted.

github-actions · 2025-02-06T09:26:20Z

Size Change: -221 B (-0.01%)

Total Size: 2 MB

Filename	Size	Change
`./dist/assets/css/googlesitekit-admin-css-********************.min.css`	62.6 kB	+43 B (+0.07%)
`./dist/assets/js/googlesitekit-modules-analytics-4-********************.js`	192 kB	-94 B (-0.05%)
`./dist/assets/js/googlesitekit-settings-********************.js`	129 kB	-92 B (-0.07%)
`./dist/assets/js/googlesitekit-user-input-********************.js`	43.9 kB	-78 B (-0.18%)

ℹ️ View Unchanged

Filename	Size
`./dist/assets/css/googlesitekit-adminbar-css-********************.min.css`	11.8 kB
`./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css`	846 B
`./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css`	8.48 kB
`./dist/assets/js/33-********************.js`	2.76 kB
`./dist/assets/js/34-********************.js`	2.25 kB
`./dist/assets/js/35-********************.js`	3.64 kB
`./dist/assets/js/36-********************.js`	935 B
`./dist/assets/js/37-********************.js`	892 B
`./dist/assets/js/38-********************.js`	1.61 kB
`./dist/assets/js/39-********************.js`	1.57 kB
`./dist/assets/js/40-********************.js`	1.61 kB
`./dist/assets/js/41-********************.js`	1.59 kB
`./dist/assets/js/42-********************.js`	1.83 kB
`./dist/assets/js/43-********************.js`	3.11 kB
`./dist/assets/js/analytics-advanced-tracking-********************.js`	901 B
`./dist/assets/js/googlesitekit-activation-********************.js`	23.7 kB
`./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js`	54.3 kB
`./dist/assets/js/googlesitekit-adminbar-********************.js`	34.8 kB
`./dist/assets/js/googlesitekit-api-********************.js`	10.1 kB
`./dist/assets/js/googlesitekit-components-gm2-********************.js`	6.46 kB
`./dist/assets/js/googlesitekit-components-gm3-********************.js`	10.1 kB
`./dist/assets/js/googlesitekit-consent-mode-********************.js`	25.6 kB
`./dist/assets/js/googlesitekit-data-********************.js`	2.37 kB
`./dist/assets/js/googlesitekit-datastore-forms-********************.js`	8.97 kB
`./dist/assets/js/googlesitekit-datastore-location-********************.js`	2.09 kB
`./dist/assets/js/googlesitekit-datastore-site-********************.js`	20.2 kB
`./dist/assets/js/googlesitekit-datastore-ui-********************.js`	10 kB
`./dist/assets/js/googlesitekit-datastore-user-********************.js`	28.4 kB
`./dist/assets/js/googlesitekit-entity-dashboard-********************.js`	82.9 kB
`./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js`	646 B
`./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js`	624 B
`./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js`	630 B
`./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js`	712 B
`./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js`	675 B
`./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js`	634 B
`./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js`	657 B
`./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js`	633 B
`./dist/assets/js/googlesitekit-i18n-********************.js`	3.93 kB
`./dist/assets/js/googlesitekit-main-dashboard-********************.js`	163 kB
`./dist/assets/js/googlesitekit-metric-selection-********************.js`	52.1 kB
`./dist/assets/js/googlesitekit-modules-********************.js`	22.3 kB
`./dist/assets/js/googlesitekit-modules-ads-********************.js`	36.1 kB
`./dist/assets/js/googlesitekit-modules-adsense-********************.js`	116 kB
`./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js`	22.7 kB
`./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js`	42.2 kB
`./dist/assets/js/googlesitekit-modules-search-console-********************.js`	69.5 kB
`./dist/assets/js/googlesitekit-modules-sign-in-with-google-********************.js`	32.5 kB
`./dist/assets/js/googlesitekit-modules-tagmanager-********************.js`	32.1 kB
`./dist/assets/js/googlesitekit-notifications-********************.js`	43.3 kB
`./dist/assets/js/googlesitekit-polyfills-********************.js`	378 B
`./dist/assets/js/googlesitekit-reader-revenue-manager-block-editor-********************.js`	477 B
`./dist/assets/js/googlesitekit-splash-********************.js`	68.9 kB
`./dist/assets/js/googlesitekit-vendor-********************.js`	325 kB
`./dist/assets/js/googlesitekit-widgets-********************.js`	105 kB
`./dist/assets/js/googlesitekit-wp-dashboard-********************.js`	63.3 kB
`./dist/assets/js/runtime-********************.js`	1.4 kB

_{compressed-size-action}

aaemnnosttv

Thanks @zutigrm – just a few points to address, otherwise this is almost good to go.

aaemnnosttv · 2025-02-06T18:23:42Z

assets/sass/components/user-input/googlesitekit-user-input-questions.scss

@@ -54,6 +54,10 @@
 		display: flex;
 		flex-direction: column;

+		@media (min-width: $bp-wpdb3) {


This variable is for a breakpoint which is defined as specific to the WP dashboard, so we shouldn't be using it on other screens.

Please update all remaining instances in this PR.

aaemnnosttv · 2025-02-07T03:50:46Z

assets/js/components/user-input/util/constants.js

 				'google-site-kit'
 			),
 			description: __(
-				'Based on your answers, Site Kit will tailor the metrics and recommendations you see on your dashboard to help you make progress in these areas',
+				'Based on your answer, Site Kit will suggest the metrics you see on your dashboard to help you track how close you’re getting to your specific goals',


Are we sure these are all supposed to have the same description? I see it is this way in the design but it's worth double checking to make sure that is correct. If so, we can extract it to a variable that's translated once to make that a bit more explicit as well.

Thanks. Sure, will double check with Sigal. So far all the changes in Figma for ACR were intended and considered latest, or source of truth. Will let you know once Sigal gets back to me on this

Confirmed that it is intentional, moved content to a variable

aaemnnosttv

Thanks @zutigrm – just the one thing left to address – please always make sure to consider feedback in the context of the full change; reviewers shouldn't need to comment on each instance where the same feedback applies.

aaemnnosttv · 2025-02-13T20:27:52Z

assets/sass/components/user-input/googlesitekit-user-input-questions.scss

@@ -54,7 +54,7 @@
 		display: flex;
 		flex-direction: column;

-		@media (min-width: $bp-wpdb3) {
+		@media (min-width: 1500px) {


Given this same breakpoint is used in several places, let's define a new bp- variable for it.

oh indeed, sorry about that, totally forgot I am using it in more than one place

aaemnnosttv · 2025-02-13T20:28:59Z

assets/sass/components/user-input/googlesitekit-user-input-questions.scss

@@ -54,6 +54,10 @@
 		display: flex;
 		flex-direction: column;

+		@media (min-width: $bp-wpdb3) {


Please update all remaining instances in this PR.

zutigrm · 2025-02-14T10:51:09Z

Thanks @aaemnnosttv updated PR and also replaced all bp-wpdb3 usages with new variable (outside of wp dashboard usage of course)

aaemnnosttv

LGTM, thanks 👍

zutigrm added 5 commits February 5, 2025 17:11

Update copy in constants.

f0838f6

Update copy in UserInputPreview.

f950067

Remove extra padding.

56a9664

Update layout spacing for desktop and wider desktop screens.

df83217

Merge remote-tracking branch 'origin/develop' into bug/10040-input-copy.

bd19b8b

zutigrm added 3 commits February 6, 2025 14:24

Increase the column size.

8cfc69b

Make a horizontal spacing between equal columns.

f33468a

Unset padding for user preview in settings.

4a26f0b

aaemnnosttv requested changes Feb 7, 2025

View reviewed changes

zutigrm added 2 commits February 12, 2025 10:20

Merge remote-tracking branch 'origin/develop' into bug/10040-input-copy.

68f2e38

Update per CR feedback.

977c600

aaemnnosttv reviewed Feb 13, 2025

View reviewed changes

zutigrm added 2 commits February 14, 2025 11:33

Merge remote-tracking branch 'origin/develop' into bug/10040-input-copy.

5e22669

Add bp-xxxlarge and replace the usage of wpdb3.

0bb61a1

aaemnnosttv approved these changes Feb 14, 2025

View reviewed changes

aaemnnosttv merged commit a5f136a into develop Feb 18, 2025
20 of 22 checks passed

aaemnnosttv deleted the bug/10040-input-copy branch February 18, 2025 20:42

aaemnnosttv mentioned this pull request Feb 18, 2025

Input questionnaire copy not the same as Figma designs #10040

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug/10040 input copy #10183

Bug/10040 input copy #10183

zutigrm commented Feb 6, 2025

github-actions bot commented Feb 6, 2025 •

edited

Loading

github-actions bot commented Feb 6, 2025 •

edited

Loading

aaemnnosttv left a comment

aaemnnosttv Feb 6, 2025

aaemnnosttv Feb 13, 2025

aaemnnosttv Feb 7, 2025

zutigrm Feb 10, 2025 •

edited

Loading

zutigrm Feb 12, 2025

aaemnnosttv left a comment

aaemnnosttv Feb 13, 2025

zutigrm Feb 14, 2025

aaemnnosttv Feb 13, 2025

zutigrm commented Feb 14, 2025

aaemnnosttv left a comment

Bug/10040 input copy #10183

Bug/10040 input copy #10183

Conversation

zutigrm commented Feb 6, 2025

Summary

Relevant technical choices

PR Author Checklist

Code Reviewer Checklist

Merge Reviewer Checklist

github-actions bot commented Feb 6, 2025 • edited Loading

github-actions bot commented Feb 6, 2025 • edited Loading

aaemnnosttv left a comment

Choose a reason for hiding this comment

aaemnnosttv Feb 6, 2025

Choose a reason for hiding this comment

aaemnnosttv Feb 13, 2025

Choose a reason for hiding this comment

aaemnnosttv Feb 7, 2025

Choose a reason for hiding this comment

zutigrm Feb 10, 2025 • edited Loading

Choose a reason for hiding this comment

zutigrm Feb 12, 2025

Choose a reason for hiding this comment

aaemnnosttv left a comment

Choose a reason for hiding this comment

aaemnnosttv Feb 13, 2025

Choose a reason for hiding this comment

zutigrm Feb 14, 2025

Choose a reason for hiding this comment

aaemnnosttv Feb 13, 2025

Choose a reason for hiding this comment

zutigrm commented Feb 14, 2025

aaemnnosttv left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 6, 2025 •

edited

Loading

github-actions bot commented Feb 6, 2025 •

edited

Loading

zutigrm Feb 10, 2025 •

edited

Loading