-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RRM introductory notification for monetization. #10224
Add RRM introductory notification for monetization. #10224
Conversation
Build files for 0143b42 have been deleted. |
Size Change: +4.43 kB (+0.22%) Total Size: 2 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this, thank you @ankitrox!
I've left a few comments for your consideration. However, as they're quite minor, I'll go ahead and apply the fixes myself. I hope that is okay, thanks!
...js/modules/reader-revenue-manager/components/dashboard/RRMIntroductoryOverlayNotification.js
Outdated
Show resolved
Hide resolved
...js/modules/reader-revenue-manager/components/dashboard/RRMIntroductoryOverlayNotification.js
Outdated
Show resolved
Hide resolved
...js/modules/reader-revenue-manager/components/dashboard/RRMIntroductoryOverlayNotification.js
Outdated
Show resolved
Hide resolved
...js/modules/reader-revenue-manager/components/dashboard/RRMIntroductoryOverlayNotification.js
Outdated
Show resolved
Hide resolved
...js/modules/reader-revenue-manager/components/dashboard/RRMIntroductoryOverlayNotification.js
Outdated
Show resolved
Hide resolved
...es/reader-revenue-manager/components/dashboard/RRMIntroductoryOverlayNotification.stories.js
Outdated
Show resolved
Hide resolved
...es/reader-revenue-manager/components/dashboard/RRMIntroductoryOverlayNotification.stories.js
Outdated
Show resolved
Hide resolved
...dules/reader-revenue-manager/components/dashboard/RRMIntroductoryOverlayNotification.test.js
Outdated
Show resolved
Hide resolved
...dules/reader-revenue-manager/components/dashboard/RRMIntroductoryOverlayNotification.test.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
Note: I've verified that the failing E2E test in CI is unrelated to this PR.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist