Issue / 10193 Updates to SetupMainPAX Component
#10239
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DTextField component.
|
Build files for 2fd8332 are ready:
|
|
Size Change: +1.55 kB (+0.07%) Total Size: 2.08 MB
ℹ️ View Unchanged
|
…s-to-setupmainpax-component.
zutigrm
reviewed
Feb 25, 2025
| ADS_WOOCOMMERCE_REDIRECT_MODAL_DISMISS_KEY | ||
| ) | ||
| ); | ||
| const shouldShowWooCommerceRedirectModal = useSelect( ( select ) => { |
There was a problem hiding this comment.
Won't work until #10175 is merged so these selectors are available
zutigrm
reviewed
Feb 25, 2025
Comment on lines
-75
to
+79
| { __( 'Conversion Tracking ID', 'google-site-kit' ) } | ||
| </h4> | ||
| { ! hideHeading && ( | ||
| <h4 className="googlesitekit-settings-module__fields-group-title"> | ||
| { __( 'Conversion ID', 'google-site-kit' ) } |
There was a problem hiding this comment.
Here and all other instances - the label is being changed, there is a comment in Figma regarding this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
<SetupMainPAX>Component to Accommodate New Layout #10193Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist