Implement SkPoint class & SkPathMeasure #179
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding class implementation for SkPoint and SkPathMeasure.
I tried getting the SkPathMeasure to work with the following embind:
But I kept on getting the error
UnboundTypeError, Cannot call SkPathMeasure._getPosTan due to unbound types: 0x2c03
It seems when using a value_array as a raw pointer there are difficulties with properly binding the C++ types to their JavaScript equivalents.
I would also like to implement
SkPathMeasure::getMatrix
but this would also require binding the SkMatrix withclass_<SkMatrix>
, and before I do that I wanted to check in with you If I'm missing something or if this is the way to go.