Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing some titles in the jsguide.html file, under "3 Source file structure" title + seeing the table of contents with delay . #655

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

ellietms
Copy link

Hi, I realised we are missing some titles under the 3 Source file structure section.
JavascriptGuide

it shows us 3.3 and we do not have 3.3.1, 3.3.2 but we have 3.3.3.
The Table contents are being created inside of the "include/jsguide.js" with pure javascript.
I added some comments that where I think the issue is happening.

one more thing is when I refresh the page, it takes longer for me to see all the links in my table of contents.
It is slow.

@google-cla google-cla bot added the cla: yes label Nov 29, 2021
@ellietms ellietms changed the title Missing some titles in the jsguide.html file, under "3 Source file structure" title + Refreshing the page is slow. Missing some titles in the jsguide.html file, under "3 Source file structure" title + seeing the the links and table content after refreshing the page is slow. Nov 29, 2021
@ellietms ellietms changed the title Missing some titles in the jsguide.html file, under "3 Source file structure" title + seeing the the links and table content after refreshing the page is slow. Missing some titles in the jsguide.html file, under "3 Source file structure" title + seeing the table of contents with delay . Nov 29, 2021
Copy link

@devvsakib devvsakib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not mandatory to use a comma after the last element, also single quote or double quote doesn't matter.
LGTM

Copy link
Member

@vapier vapier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's hard to tell functional from style changes in here. please create a separate PR/commit for just the style changes.

@vapier vapier removed the cla: yes label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants