fix problem with ip concat with warnning messages #4451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-nogikh
reviewed
Jan 23, 2024
There was a problem hiding this comment.
Thanks for sharing the fix!
Please also note the ci / aux check failures. Specifically, there are rules that determine how a commit title/description should look like:
https://github.com/google/syzkaller/blob/master/docs/contributing.md#commits
| @@ -119,11 +119,21 @@ func (inst *instance) boot() error { | |||
| if inst.debug { | |||
| log.Logf(0, "getting IP of %v", inst.vmx) | |||
| } | |||
| ip, err := osutil.RunCmd(5*time.Minute, "", "vmrun", "getGuestIPAddress", inst.vmx, "-wait") | |||
| ipCmd := exec.Command("vmrun", "getGuestIPAddress", inst.vmx, "-wait") | |||
| ipOutput, err := ipCmd.CombinedOutput() | |||
There was a problem hiding this comment.
Does the tool print the warning to stderr?
If yes, it might be easier to take the stdout output, i.e. ip, err := ipCmd.Output() instead of ipCmd.CombinedOutput(). Then you won't need to parse out the address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before sending a pull request, please review Contribution Guidelines:
https://github.com/google/syzkaller/blob/master/docs/contributing.md
Solve problem with adding warning messages to extracted IP address of vmware machine