Remove a confusing comment. #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
When I saw a Copybara update for this dependency I wondered whether the comment meant that the version had to stay at a particular level to "work around a ubuntu bug". But I think it was just saying, in 2015, that the default maven-jar-plugin version had the bug and we needed to use a more recent explicit version. RELNOTES=n/a PiperOrigin-RevId: 624940222
copybara-service
bot
force-pushed
the
test_624938533
branch
from
d2ae346
to
b74edad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a confusing comment.
When I saw a Copybara update for this dependency I wondered whether the comment meant that the version had to stay at a particular level to "work around a ubuntu bug". But I think it was just saying, in 2015, that the default maven-jar-plugin version had the bug and we needed to use a more recent explicit version.
RELNOTES=n/a