Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the dependencies group with 5 updates #1348

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 7, 2024

Bumps the dependencies group with 5 updates:

Package From To
com.google.errorprone:error_prone_annotations 2.32.0 2.33.0
org.ow2.asm:asm 9.7 9.7.1
com.google.jsinterop:jsinterop-annotations 2.0.0 2.1.0
org.apache.maven.plugins:maven-javadoc-plugin 3.10.0 3.10.1
org.apache.maven.plugins:maven-surefire-plugin 3.5.0 3.5.1

Updates com.google.errorprone:error_prone_annotations from 2.32.0 to 2.33.0

Release notes

Sourced from com.google.errorprone:error_prone_annotations's releases.

Error Prone 2.33.0

Similar to release 2.32.0, the minimum supported JDK version to run Error Prone is JDK 17 (#3803). Using Error Prone to compile code that is deployed to earlier versions is still fully supported, but will require using JDK 17 or newer for compilation and setting --release or -source/-target/-bootclasspath.

Changes:

New checks:

Full changelog: google/error-prone@v2.32.0...v2.33.0

Commits
  • 7a67f20 Release Error Prone 2.33.0
  • f1f7955 Remove out of place .. Previously, the error message was:
  • c885150 Add a regression test for b/369862572
  • 2b78c1f Avoid a possible IndexOutOfBoundsException in MemberName.
  • 47dd2a8 Suggest Splitter.on(Pattern.compile(...)) instead of Splitter.onPattern
  • 50d0983 Add some missing testdata/ prefixes.
  • f82fb66 Fix typos
  • fb1a05b Update protobuf version
  • be99217 Extend MissingOverride to require @​Override on "an explicitly declared access...
  • 2c04ada Support toSeconds in DurationToLongTimeUnit
  • Additional commits viewable in compare view

Updates org.ow2.asm:asm from 9.7 to 9.7.1

Updates com.google.jsinterop:jsinterop-annotations from 2.0.0 to 2.1.0

Release notes

Sourced from com.google.jsinterop:jsinterop-annotations's releases.

2.0.2

Incremental release with bug fixes

2.0.1

Release with the visibility fix on Bazel targets.

Commits
  • 38babd1 Run samples test in github CI only if the test exists
  • 984c139 Fix github CI that was accidentally overridden.
  • 8e0310a Import jsinterop_annotations as a JAR only rather than the full java_library
  • 4032fcc Use @​com_google_j2cl//build_defs:workspace.bzl to setup the j2cl workspace.
  • d786051 Enable Java 11 for J2CL compiler itself.
  • f769a10 Add back javadoc for promise in elemental2 which does not use jsinterop_gener...
  • 4b6d3ba Build and add javadoc jar in release scripts.
  • 383154d Generate javadoc using javadoc_library from bazel-common
  • 870c9dd Remove license targets for now.
  • b8eedde Remove rules_license from WORKSPACE.
  • Additional commits viewable in compare view

Updates org.apache.maven.plugins:maven-javadoc-plugin from 3.10.0 to 3.10.1

Release notes

Sourced from org.apache.maven.plugins:maven-javadoc-plugin's releases.

maven-javadoc-plugin-3.10.1

What's Changed

Full Changelog: apache/maven-javadoc-plugin@maven-javadoc-plugin-3.10.0...maven-javadoc-plugin-3.10.1

Commits
  • 091785b [maven-release-plugin] prepare release maven-javadoc-plugin-3.10.1
  • cde7c56 [MJAVADOC-812] [REGRESSION] maven-javadoc-plugin 3.10.0 creates empty JARs
  • db6d7f6 [MJAVADOC-811] javadoc.bat fails to execute on Windows when project is not on...
  • a737e16 Bump commons-io:commons-io from 2.16.1 to 2.17.0
  • 577c204 Bump org.codehaus.plexus:plexus-io from 3.5.0 to 3.5.1
  • ff52cff Bump org.apache.commons:commons-lang3 from 3.16.0 to 3.17.0
  • 54a7651 Add goal prefix
  • a424c6b [MJAVADOC-810] [REGRESSION] MJAVADOC-791 causes forked Maven execution fail i...
  • d9c0002 [maven-release-plugin] prepare for next development iteration
  • See full diff in compare view

Updates org.apache.maven.plugins:maven-surefire-plugin from 3.5.0 to 3.5.1

Release notes

Sourced from org.apache.maven.plugins:maven-surefire-plugin's releases.

3.5.1

🚀 New features and improvements

🐛 Bug Fixes

📦 Dependency updates

👻 Maintenance

Commits
  • a69b0f8 [maven-release-plugin] prepare release surefire-3.5.1
  • ccc54d0 [SUREFIRE-2273] Bump org.hamcrest:hamcrest from 2.2 to 3.0 (#784)
  • ab77c35 [SUREFIRE-2272] Bump org.codehaus.plexus:plexus-java from 1.2.0 to 1.3.0 - JD...
  • 93317ff [SUREFIRE-2269] Allow fail during clean in surefire-its
  • d7f4dbb [SUREFIRE-2270] Use JUnit5 in surefire-shadefire
  • 7a98850 Drop comment from jira integration
  • b2aa8a6 [SUREFIRE-2267] Packages for commons-codec should be relocated in surefire-sh...
  • a928255 [SUREFIRE-1737] Fix disable in statelessTestsetReporter
  • 4584ebb [SUREFIRE-2226] Upgrade to Maven Verifier 2.0.0-M1
  • 5aa3515 [SUREFIRE-2266] Execute ITs in parallel
  • Additional commits viewable in compare view

Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
com.google.jsinterop:jsinterop-annotations [>= 2.1.a, < 2.2]
com.google.jsinterop:jsinterop-annotations [< 2.1, > 2.0.0]

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Oct 7, 2024
@cpovirk
Copy link
Member

cpovirk commented Oct 7, 2024

GWT doesn't like the jsinterop-annotations upgrade under Java 8, as in #1306 and #1305:

[INFO] java.lang.UnsupportedClassVersionError: jsinterop/annotations/JsProperty has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0

@dependabot ignore com.google.jsinterop:jsinterop-annotations minor version

@cpovirk
Copy link
Member

cpovirk commented Oct 8, 2024

@dependabot ignore com.google.jsinterop:jsinterop-annotations minor version

Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 8, 2024

OK, I won't notify you about version 2.1.x of com.google.jsinterop:jsinterop-annotations again, unless you unignore it.

@dependabot dependabot bot force-pushed the dependabot/maven/dependencies-53c5af25e8 branch from 52ad2c3 to 33b9760 Compare October 8, 2024 10:48
@cpovirk
Copy link
Member

cpovirk commented Oct 8, 2024

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/maven/dependencies-53c5af25e8 branch from 33b9760 to 919707c Compare October 8, 2024 10:50
@cpovirk
Copy link
Member

cpovirk commented Oct 8, 2024

Dependabot keeps trying to bump com.google.jsinterop:jsinterop-annotations to 2.1.0, even as it reports:

Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
com.google.jsinterop:jsinterop-annotations [>= 2.1.a, < 2.2]
com.google.jsinterop:jsinterop-annotations [< 2.1, > 2.0.0]

I wonder if that "2.1.a" syntax is off? Or I wonder if Dependabot is getting confused by the multiple ignore conditions for the single package? I ran through a bunch of Dependabot bug reports and found various issues about ignore conditions, albeit largely for ignore conditions that are written into the Dependabot config:

I may make another attempt or two....

@cpovirk
Copy link
Member

cpovirk commented Oct 8, 2024

@dependabot unignore com.google.jsinterop:jsinterop-annotations

Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 8, 2024

OK, I will stop ignoring the com.google.jsinterop:jsinterop-annotations dependency.

@dependabot dependabot bot force-pushed the dependabot/maven/dependencies-53c5af25e8 branch from 919707c to 7d82bfc Compare October 8, 2024 12:51
@cpovirk
Copy link
Member

cpovirk commented Oct 8, 2024

https://github.com/dependabot ignore com.google.jsinterop:jsinterop-annotations minor version

Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 8, 2024

OK, I won't notify you about version 2.1.x of com.google.jsinterop:jsinterop-annotations again, unless you unignore it.

@dependabot dependabot bot force-pushed the dependabot/maven/dependencies-53c5af25e8 branch from 7d82bfc to f791c10 Compare October 8, 2024 12:54
@cpovirk
Copy link
Member

cpovirk commented Oct 8, 2024

The unignore command doesn't appear to have actually changed what Dependabot is ignoring: I still see two entries in the table. Or maybe it undid only the condition that applies to the current version? [edit: i.e.,I didn't check the table until after I'd told it to ignore the current minor version again.]

@cpovirk
Copy link
Member

cpovirk commented Oct 8, 2024

@dependabot ignore com.google.jsinterop:jsinterop-annotations patch version

Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 8, 2024

OK, I won't notify you about version 2.1.0 of com.google.jsinterop:jsinterop-annotations again, unless you unignore it.

Bumps the dependencies group with 5 updates:

| Package | From | To |
| --- | --- | --- |
| [com.google.errorprone:error_prone_annotations](https://github.com/google/error-prone) | `2.32.0` | `2.33.0` |
| org.ow2.asm:asm | `9.7` | `9.7.1` |
| [com.google.jsinterop:jsinterop-annotations](https://github.com/google/jsinterop-annotations) | `2.0.0` | `2.1.0` |
| [org.apache.maven.plugins:maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) | `3.10.0` | `3.10.1` |
| [org.apache.maven.plugins:maven-surefire-plugin](https://github.com/apache/maven-surefire) | `3.5.0` | `3.5.1` |


Updates `com.google.errorprone:error_prone_annotations` from 2.32.0 to 2.33.0
- [Release notes](https://github.com/google/error-prone/releases)
- [Commits](google/error-prone@v2.32.0...v2.33.0)

Updates `org.ow2.asm:asm` from 9.7 to 9.7.1

Updates `com.google.jsinterop:jsinterop-annotations` from 2.0.0 to 2.1.0
- [Release notes](https://github.com/google/jsinterop-annotations/releases)
- [Commits](google/jsinterop-annotations@2.0.0...2.1.0)

Updates `org.apache.maven.plugins:maven-javadoc-plugin` from 3.10.0 to 3.10.1
- [Release notes](https://github.com/apache/maven-javadoc-plugin/releases)
- [Commits](apache/maven-javadoc-plugin@maven-javadoc-plugin-3.10.0...maven-javadoc-plugin-3.10.1)

Updates `org.apache.maven.plugins:maven-surefire-plugin` from 3.5.0 to 3.5.1
- [Release notes](https://github.com/apache/maven-surefire/releases)
- [Commits](apache/maven-surefire@surefire-3.5.0...surefire-3.5.1)

---
updated-dependencies:
- dependency-name: com.google.errorprone:error_prone_annotations
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dependencies
- dependency-name: org.ow2.asm:asm
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dependencies
- dependency-name: com.google.jsinterop:jsinterop-annotations
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dependencies
- dependency-name: org.apache.maven.plugins:maven-javadoc-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dependencies
- dependency-name: org.apache.maven.plugins:maven-surefire-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/maven/dependencies-53c5af25e8 branch from f791c10 to c106c41 Compare October 8, 2024 13:02
@cpovirk
Copy link
Member

cpovirk commented Oct 8, 2024

@dependabot show com.google.jsinterop:jsinterop-annotations ignore conditions

Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 8, 2024

Ignore Conditions
Dependency Ignore Condition
com.google.jsinterop:jsinterop-annotations [>= 2.1.0.a, < 2.1.1]
com.google.jsinterop:jsinterop-annotations [>= 2.1.a, < 2.2]

@cpovirk
Copy link
Member

cpovirk commented Oct 8, 2024

@dependabot unignore com.google.jsinterop:jsinterop-annotations [>= 2.1.0.a, < 2.1.1]

Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 8, 2024

OK, I will stop ignoring the com.google.jsinterop:jsinterop-annotations dependency and its ignore condition [>= 2.1.0.a, < 2.1.1].

Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 8, 2024

Looks like this PR is already up-to-date with master, and has been recreated more than 5 times in the last 24 hours!

@cpovirk
Copy link
Member

cpovirk commented Oct 8, 2024

@dependabot unignore com.google.jsinterop:jsinterop-annotations [>= 2.1.a, < 2.2]

Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 8, 2024

OK, I will stop ignoring the com.google.jsinterop:jsinterop-annotations dependency and its ignore condition [>= 2.1.a, < 2.2].

Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 8, 2024

Looks like this PR is already up-to-date with master, and has been recreated more than 5 times in the last 24 hours!

@cpovirk
Copy link
Member

cpovirk commented Oct 8, 2024

also noting for the record that the list in #1348 (comment)...

com.google.jsinterop:jsinterop-annotations [>= 2.1.0.a, < 2.1.1]
com.google.jsinterop:jsinterop-annotations [>= 2.1.a, < 2.2]

...does not match the list in #1348 (comment) at last glance...

com.google.jsinterop:jsinterop-annotations [>= 2.1.a, < 2.2]
com.google.jsinterop:jsinterop-annotations [< 2.1, > 2.0.0]

@cpovirk
Copy link
Member

cpovirk commented Oct 8, 2024

@dependabot show com.google.jsinterop:jsinterop-annotations ignore conditions

Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 8, 2024

No ignore conditions found for the dependency com.google.jsinterop:jsinterop-annotations

@cpovirk
Copy link
Member

cpovirk commented Oct 8, 2024

@dependabot ignore com.google.jsinterop:jsinterop-annotations patch version

Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 8, 2024

OK, I won't notify you about version 2.1.0 of com.google.jsinterop:jsinterop-annotations again, unless you unignore it.

Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 8, 2024

Looks like this PR is already up-to-date with master, and has been recreated more than 5 times in the last 24 hours!

@cpovirk
Copy link
Member

cpovirk commented Oct 8, 2024

@dependabot show com.google.jsinterop:jsinterop-annotations ignore conditions

Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 8, 2024

Ignore Conditions
Dependency Ignore Condition
com.google.jsinterop:jsinterop-annotations [>= 2.1.0.a, < 2.1.1]

@cpovirk
Copy link
Member

cpovirk commented Oct 8, 2024

@dependabot ignore com.google.jsinterop:jsinterop-annotations 2.1.0

@cpovirk
Copy link
Member

cpovirk commented Oct 8, 2024

@dependabot ignore com.google.jsinterop:jsinterop-annotations major version

Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 8, 2024

OK, I won't notify you about version 2.x.x of com.google.jsinterop:jsinterop-annotations again, unless you unignore it.

Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 8, 2024

Looks like this PR is already up-to-date with master, and has been recreated more than 5 times in the last 24 hours!

@cpovirk
Copy link
Member

cpovirk commented Oct 8, 2024

@dependabot show com.google.jsinterop:jsinterop-annotations ignore conditions

Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 8, 2024

Ignore Conditions
Dependency Ignore Condition
com.google.jsinterop:jsinterop-annotations [>= 2.a, < 3]
com.google.jsinterop:jsinterop-annotations [>= 2.1.0.a, < 2.1.1]

@cpovirk
Copy link
Member

cpovirk commented Oct 8, 2024

@dependabot recreate

Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 8, 2024

Looks like this PR is already up-to-date with master, and has been recreated more than 5 times in the last 24 hours!

@cpovirk
Copy link
Member

cpovirk commented Oct 8, 2024

https://github.com/dependabot ignore com.google.jsinterop:jsinterop-annotations [>= 2.1.0, < 2.1.1]

@netdpb netdpb requested review from cpovirk and removed request for cpovirk October 8, 2024 14:02
@cpovirk cpovirk added the P2 has an ETA label Oct 8, 2024
copybara-service bot pushed a commit that referenced this pull request Oct 8, 2024
…ncluding.

Fixes #1348

RELNOTES=n/a
PiperOrigin-RevId: 683613504
copybara-service bot pushed a commit that referenced this pull request Oct 8, 2024
…ncluding.

Fixes #1348

RELNOTES=n/a
PiperOrigin-RevId: 683613504
@copybara-service copybara-service bot closed this in c6ddbc8 Oct 8, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 8, 2024

This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests.

To ignore these dependencies, configure ignore rules in dependabot.yml

@dependabot dependabot bot deleted the dependabot/maven/dependencies-53c5af25e8 branch October 8, 2024 15:11
@cpovirk
Copy link
Member

cpovirk commented Oct 8, 2024

To ignore these dependencies, configure ignore rules in dependabot.yml

I guess that's another thing that we can try if we continue to have trouble with configuration based on PR comments. But as noted above, users have reported problems with configurat based on dependabot.yml, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code P2 has an ETA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant