Throw a plain AssertionError if ComparisonFailure is unavailable, for real this time. #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_353318639
branch
2 times, most recently
from
936de62
to
16ee13a
Compare
… real this time. This should *really* let users exclude the JUnit 4 dependency -- again, as long as they don't use Expect, ExpectFailure, or TruthJUnit (i.e., assume()). This change makes the previously failing test procedure described in #333 (comment) pass. RELNOTES=Made it possible for users to exclude our JUnit 4 dependency and still use standard Truth assertions -- *really* this time. (JUnit 4 is still required for some advanced features, like `Expect`, `ExpectFailure`, and `TruthJUnit.assume()`.) PiperOrigin-RevId: 353416036
copybara-service
bot
force-pushed
the
test_353318639
branch
from
16ee13a
to
948f3ed
Compare
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw a plain AssertionError if ComparisonFailure is unavailable, for real this time.
This should really let users exclude the JUnit 4 dependency -- again, as long as they don't use Expect, ExpectFailure, or TruthJUnit (i.e., assume()).
This change makes the previously failing test procedure described in #333 (comment) pass.
RELNOTES=Made it possible for users to exclude our JUnit 4 dependency and still use standard Truth assertions -- really this time. (JUnit 4 is still required for some advanced features, like
Expect,ExpectFailure, andTruthJUnit.assume().)