Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix val_cnt for if #706

Merged
merged 6 commits into from
Dec 23, 2024
Merged

Fix val_cnt for if #706

merged 6 commits into from
Dec 23, 2024

Conversation

zhouwfang
Copy link
Member

#46

@zhouwfang zhouwfang requested a review from ia0 as a code owner December 18, 2024 07:19
@zhouwfang
Copy link
Member Author

@ia0 I posted zhouwfang#5 to show the debug asserts added for val_cnt and pop_cnt with a question. Could you take a look? Thanks.

ia0
ia0 reviewed Dec 23, 2024
View reviewed changes
Copy link
Member

@ia0 ia0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pushing a change with my suggestions.

crates/interpreter/src/valid.rs Show resolved Hide resolved
crates/interpreter/src/valid.rs Outdated Show resolved Hide resolved
@ia0 ia0 merged commit 18bedde into google:dev/fast-interp Dec 23, 2024
20 checks passed
@zhouwfang zhouwfang deleted the fix-valcnt-for-if branch December 24, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ia0 ia0 ia0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhouwfang @ia0