Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prev_stack in Frame #707

Merged
merged 3 commits into from
Dec 24, 2024

Conversation

zhouwfang
Copy link
Member

@zhouwfang zhouwfang commented Dec 23, 2024

It improves the performance by removing the costly last_frame_values_cnt().

On linux, CoreMark result: 39.795715 (in 17.853s). cf. CoreMark result was about 37 in 19s in #705.

#46

Improve the performance by removing last_frame_values_cnt()
@zhouwfang zhouwfang requested a review from ia0 as a code owner December 23, 2024 01:58
Copy link
Member

@ia0 ia0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM modulo the Option<usize> which seems redundant.

crates/interpreter/src/exec.rs Outdated Show resolved Hide resolved
@zhouwfang zhouwfang requested a review from ia0 December 23, 2024 16:50
@ia0 ia0 merged commit 9d47336 into google:dev/fast-interp Dec 24, 2024
20 checks passed
@zhouwfang zhouwfang deleted the add-prev-stack-in-frame branch December 24, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants