Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

open_dataset bug with zarr dataset #439

Merged
merged 2 commits into from
Feb 20, 2024
Merged

open_dataset bug with zarr dataset #439

merged 2 commits into from
Feb 20, 2024

Conversation

DarshanSP19
Copy link
Collaborator

  • Fix bug related to opening the dataset. While working with the zarr dataset, it's throwing an exception.
Unable to open dataset.
  • Modify dataset opening logic.

@DarshanSP19 DarshanSP19 self-assigned this Feb 16, 2024
mahrsee1997
mahrsee1997 reviewed Feb 16, 2024
View reviewed changes
mahrsee1997
mahrsee1997 approved these changes Feb 16, 2024
View reviewed changes
Copy link
Collaborator

@mahrsee1997 mahrsee1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit otherwise LGTM!

@mahrsee1997 mahrsee1997 merged commit 785c6f1 into main Feb 20, 2024
7 checks passed
@mahrsee1997 mahrsee1997 deleted the xql-open-dataset-update branch February 20, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahrsee1997 mahrsee1997 mahrsee1997 approved these changes

Assignees

@DarshanSP19 DarshanSP19

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DarshanSP19 @mahrsee1997