-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dl-v2
handling graceful termination in license deployment
#471
Merged
mahrsee1997
merged 12 commits into
google:main
from
aniketsinghrawat:dl-v2-license-dep-graceful-termination
Sep 2, 2024
Merged
dl-v2
handling graceful termination in license deployment
#471
mahrsee1997
merged 12 commits into
google:main
from
aniketsinghrawat:dl-v2-license-dep-graceful-termination
Sep 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahrsee1997
reviewed
Aug 18, 2024
…l-v2-license-dep-graceful-termination
mahrsee1997
reviewed
Aug 21, 2024
with ThreadPoolExecutor(concurrency_limit) as executor: | ||
# Disclaimer: A license will pick always pick concurrency_limit + 1 | ||
# parition. One extra parition will be kept in threadpool task queue. | ||
|
||
log_count = 0 | ||
while True: | ||
# Fetch a request from the database | ||
request = fetch_request_from_db() | ||
# Check if SIGTERM was recived for gracefull termination. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: graceful
mahrsee1997
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.