Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dl-v2 handling graceful termination in license deployment #471

Conversation

aniketsinghrawat
Copy link
Contributor

No description provided.

with ThreadPoolExecutor(concurrency_limit) as executor:
# Disclaimer: A license will pick always pick concurrency_limit + 1
# parition. One extra parition will be kept in threadpool task queue.

log_count = 0
while True:
# Fetch a request from the database
request = fetch_request_from_db()
# Check if SIGTERM was recived for gracefull termination.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: graceful

Copy link
Collaborator

@mahrsee1997 mahrsee1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mahrsee1997 mahrsee1997 merged commit f0ead39 into google:main Sep 2, 2024
5 checks passed
@mahrsee1997 mahrsee1997 deleted the dl-v2-license-dep-graceful-termination branch September 2, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants