Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refs #935] Add nunjucks templating engine #936

Closed
wants to merge 2 commits into from

Conversation

zomars
Copy link

@zomars zomars commented May 9, 2017

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@zomars
Copy link
Author

zomars commented May 9, 2017

I signed it! My company name is: Ancla Studio

@zomars
Copy link
Author

zomars commented May 9, 2017

This implements what I proposed in #935

@addyosmani
Copy link
Contributor

@zomars Thank you very much for your contribution. We'll apologize for not commenting earlier on the RFC thread you put together. We're currently trying to limit the scope of WSK to as simple a setup as possible for most users. With that in mind, we're not going to introduce a templating system in here just yet.

@addyosmani addyosmani closed this Aug 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants