Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.14.10 #1271

Merged
merged 7 commits into from
Jan 28, 2025
Merged

Release 0.14.10 #1271

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
39fe51d
Prepare release
aomarks Jan 28, 2025
76edc74
Freshen package lock
aomarks Jan 28, 2025
5a6bb29
Fixes for TypeScript update
aomarks Jan 28, 2025
5a19d1b
Update esbuild
aomarks Jan 28, 2025
da993f3
Fix new lint errors
aomarks Jan 28, 2025
a343980
Further improve test resiliency on windows
aomarks Jan 28, 2025
285a5cc
Increase timeout and set flakiness
aomarks Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic
Versioning](https://semver.org/spec/v2.0.0.html).

## Unreleased
<!-- ## Unreleased -->

## [0.14.10] - 2025-01-28

### Fixed

Expand Down Expand Up @@ -643,7 +645,8 @@ Versioning](https://semver.org/spec/v2.0.0.html).

- Initial release.

[unreleased]: https://github.com/google/wireit/compare/v0.14.9...HEAD
[unreleased]: https://github.com/google/wireit/compare/v0.14.10...HEAD
[0.14.10]: https://github.com/google/wireit/compare/v0.14.9...v0.14.10
[0.14.9]: https://github.com/google/wireit/compare/v0.14.8...v0.14.9
[0.14.8]: https://github.com/google/wireit/compare/v0.14.7...v0.14.8
[0.14.7]: https://github.com/google/wireit/compare/v0.14.6...v0.14.7
Expand Down
3,102 changes: 1,481 additions & 1,621 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "wireit",
"version": "0.14.9",
"version": "0.14.10",
"description": "Upgrade your npm scripts to make them smarter and more efficient",
"author": "Google LLC",
"license": "Apache-2.0",
Expand Down Expand Up @@ -413,7 +413,7 @@
"@vscode/test-electron": "^2.3.8",
"@vscode/vsce": "^3.0.0",
"cmd-shim": "^7.0.0",
"esbuild": "^0.23.0",
"esbuild": "^0.24.2",
"eslint": "^9.10.0",
"eslint-plugin-no-only-tests": "^3.1.0",
"jsonc-parser": "^3.0.0",
Expand Down
4 changes: 2 additions & 2 deletions src/caching/github-actions-cache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,7 +556,7 @@ export class GitHubActionsCache implements Cache {
],
(error: unknown) => {
if (error != null) {
reject(new Error(`tar error: ${String(error)}`));
reject(new Error(`tar error: ${String(error as Error)}`));
} else {
resolve();
}
Expand Down Expand Up @@ -688,7 +688,7 @@ class GitHubActionsCacheHit implements CacheHit {
['--extract', '--file', tarballPath, '--gzip', '-P'],
(error: unknown) => {
if (error != null) {
reject(new Error(`tar error: ${String(error)}`));
reject(new Error(`tar error: ${String(error as Error)}`));
} else {
resolve();
}
Expand Down
2 changes: 1 addition & 1 deletion src/logging/debug-logger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export class DebugLogger extends SimpleLogger {
super.log(event);
}

[Symbol.dispose](): void {
override [Symbol.dispose](): void {
super[Symbol.dispose]();
this.console[Symbol.dispose]();
}
Expand Down
24 changes: 20 additions & 4 deletions src/test/failures.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,14 +529,25 @@ test(
failer.nextInvocation(),
]);
if ('code' in exitOrInvocation) {
finalExit = exitOrInvocation;
break;
if (exitOrInvocation.stderr.includes('EPERM')) {
// See note about EPERM above, it can also happen within wireit.
await new Promise((resolve) => setTimeout(resolve, 1000));
continue;
} else {
finalExit = exitOrInvocation;
break;
}
}
await rig.write('output', '1');
exitOrInvocation.exit(0);
finalExit = await wireit.exit;
if (finalExit.code !== 0) {
break;
if (finalExit.stderr.includes('EPERM')) {
// See note about EPERM above, it can also happen within wireit.
await new Promise((resolve) => setTimeout(resolve, 1000));
} else {
break;
}
}
}
} finally {
Expand Down Expand Up @@ -599,7 +610,12 @@ test(
failerInv.exit(0);
finalExit = await wireit.exit;
if (finalExit.code !== 0) {
break;
if (finalExit.stderr.includes('EPERM')) {
// See note about EPERM above, it can also happen within wireit.
await new Promise((resolve) => setTimeout(resolve, 1000));
} else {
break;
}
}
}
} finally {
Expand Down
2 changes: 1 addition & 1 deletion src/util/fs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ export async function createWriteStream(
export async function copyFile(
src: fsTypes.PathLike,
dest: fsTypes.PathLike,
flags?: number | undefined,
flags?: number,
) {
const reservation = await fileBudget.reserve();
try {
Expand Down
3 changes: 2 additions & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
"noImplicitOverride": true,
"incremental": true,
"tsBuildInfoFile": ".tsbuildinfo",
"composite": true
"composite": true,
"skipLibCheck": true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did this become necessary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These and a bunch of similar tsc errors from vscode-jsonrpc

node_modules/vscode-jsonrpc/lib/common/linkedMap.d.ts:28:5 - error TS2416: Property 'forEach' in type 'LinkedMap<K, V>' is not assignable to the same property in base type 'Map<K, V>'.
  Type '(callbackfn: (value: V, key: K, map: LinkedMap<K, V>) => void, thisArg?: any) => void' is not assignable to type '(callbackfn: (value: V, key: K, map: Map<K, V>) => void, thisArg?: any) => void'.
    Types of parameters 'callbackfn' and 'callbackfn' are incompatible.
      Types of parameters 'map' and 'map' are incompatible.
        Type 'LinkedMap<K, V>' is not assignable to type 'Map<K, V>'.
          The types returned by 'entries()' are incompatible between these types.
            Property '[Symbol.dispose]' is missing in type 'IterableIterator<[K, V]>' but required in type 'MapIterator<[K, V]>'.

28     forEach(callbackfn: (value: V, key: K, map: LinkedMap<K, V>) => void, thisArg?: any): void;
       ~~~~~~~

},
"include": ["src/**/*.ts"],
"exclude": []
Expand Down
Loading