Skip to content

Commit

Permalink
[doc] Test cargo doc under --no-default-features (#537)
Browse files Browse the repository at this point in the history
This previously wasn't possible due to the `byteorder` feature, which
has now been removed.
  • Loading branch information
joshlf authored Jan 18, 2024
1 parent 7d917bf commit 03b92f9
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -229,11 +229,6 @@ jobs:
jq -r ".packages[] | select(.name == \"zerocopy\").metadata.docs.rs.\"rustdoc-args\".[]" | tr '\n' ' ')"
export RUSTDOCFLAGS="${{ matrix.toolchain == 'nightly' && '-Z unstable-options --document-hidden-items' || '' }} $RUSTDOCFLAGS $METADATA_DOCS_RS_RUSTDOC_ARGS"
./cargo.sh +${{ matrix.toolchain }} doc --document-private-items --package ${{ matrix.crate }} ${{ matrix.features }}
# When the `byteorder` feature is disabled, `cargo doc` fails because we
# link to the `byteorder` module in doc comments. This isn't a big deal
# because we primarily care about `cargo doc` working for `docs.rs`, which
# enables the `byteorder` feature.
if: matrix.features != '--no-default-features'
# Check semver compatibility with the most recently-published version on
# crates.io. We do this in the matrix rather than in its own job so that it
Expand Down

0 comments on commit 03b92f9

Please sign in to comment.