Support 16-bit target platforms #2401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we currently can't roll our pinned nightly toolchain, and since support for the avr target which initially caused us to notice this issue was only added on nightly recently, this commit does not add a regression test. That will be done later as part of #2400 once we are able to roll our pinned nightly toolchain. Makes progress on #2400 gherrit-pr-id: I2ce6e9e0c2ba1cbe24c8cc5686e5b9b519bbf102
jswrenn
approved these changes
Feb 27, 2025
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2401 +/- ##
=======================================
Coverage 87.48% 87.48%
=======================================
Files 17 17
Lines 6279 6279
=======================================
Hits 5493 5493
Misses 786 786 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we currently can't roll our pinned nightly toolchain, and since
support for the avr target which initially caused us to notice this
issue was only added on nightly recently, this commit does not add a
regression test. That will be done later as part of #2400 once we are
able to roll our pinned nightly toolchain.
Makes progress on #2400
This PR is on branch avr-artmega.