Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype of Firestore query explain functionality #14079

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jskeet
Copy link
Collaborator

@jskeet jskeet commented Jan 10, 2025

DO NOT MERGE

This is just to demonstrate initial prototyping. Things that need fixing:

  • Rename QueryProfileInfo, probably to ExplainResults to match feat: Query Profiling java-firestore#1609
  • Create new wrapper types for the various outputs (plan summary and explain metrics).
  • Possibly create a new wrapper type for ExplainOptions, and expose a single new method accepting that instead of two new methods that vary by name.

DO NOT MERGE

This is just to demonstrate initial prototyping. Things that need
fixing:

- Rename QueryProfileInfo, probably to ExplainResults to match
  googleapis/java-firestore#1609
- Create new wrapper types for the various outputs (plan summary
  and explain metrics).
- Possibly create a new wrapper type for ExplainOptions, and expose
  a single new method accepting that instead of two new methods that
  vary by name.
@jskeet jskeet added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants