Skip to content

Commit

Permalink
misc cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
bshaffer committed Sep 20, 2024
1 parent 1c9330e commit 8ae7963
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
name: Backward Compatibility Checks
on:
pull_request:
types: [opened, synchronize, reopened, edited]
branches: ['main']
jobs:
# More info at https://github.com/Roave/BackwardCompatibilityCheck.
backwards-compatibility-check:
name: Backwards Compatibility Check
name: Breaking Change Check
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -70,11 +71,11 @@ jobs:
- name: "Print the action item"
run: |
if [[ "${{ steps.compatibility-checker.outcome }}" == 'failure' ]]; then
if [[ "${{ !startsWith(github.event.pull_request.title, 'feat') }}" ]]; then
if [[ "${{ startsWith(github.event.pull_request.title, 'feat') }}" == "true" ]]; then
echo "Action item: Change the conventional commit to use 'feat'"
exit 1
fi
elif [[ "${{ !startsWith(github.event.pull_request.title, 'feat') }}" ]]; then
elif [[ "${{ startsWith(github.event.pull_request.title, 'feat') }}" == "false" ]]; then
echo "Action item: No features found, do not use 'feat' for the conventional commit"
exit 1
fi
1 change: 1 addition & 0 deletions .github/workflows/release-checks.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
name: Release Checks
on:
pull_request:
types: [opened, synchronize, reopened, edited]
Expand Down

0 comments on commit 8ae7963

Please sign in to comment.