chore(Spanner): Make createTransactionSelector faster #7342
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply replaces the use of
decodeMessage
from the Serializer and uses themergeFromJsonString
and the protobuf class's setter method.The metrics on average are:
Using decodeMessage
When
createTransactionSelector
is called the first time: 900 us(micros)When
createTransactionSelector
is called the second time: 300 us (This is low because the Serializer caches a lot of things like proto descriptors etc).Using mergeFromJsonString
When
createTransactionSelector
is called the first time: 200 us(micros)When
createTransactionSelector
is called the second time: 150 us