Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Kafka Connect Cloud Bigtable sink connector #2466

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

prawilny
Copy link

This PR adds Kafka Connect sink connector.

The code is to land in a different repository, but the repository hasn't been created yet, so we bring the code for early review here.
The fact that it's targetting another repo is the reason of the following:

  • modification of Github Actions CI so that it executes the sink's tests instead of adding it as a new maven submodule and plugging it into existing CI
  • the code is not a submodule in the root pom.xml nor does it use any information from outside of the directory
  • maven plugins' config is duplicated
  • there is another copy of the license in the directory

Things yet to be done (in future PRs):

  • Logical types support
  • More comprehensive integration tests
    • they might include more detailed compatibility checks against the Confluent sink
  • Use of kokoro in CI

@prawilny prawilny requested review from a team as code owners January 12, 2025 14:07
Copy link

google-cla bot commented Jan 12, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: bigtable Issues related to the googleapis/java-bigtable API. labels Jan 12, 2025
Copy link

Warning: This pull request is touching the following templated files:

  • .github/workflows/ci.yaml

@prawilny prawilny force-pushed the kafka_connect_bigtable_sink branch from e2f0361 to 40ae074 Compare January 13, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant