Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Reduce code bloat by using lambdas. #1484

Merged
merged 3 commits into from
Dec 5, 2023
Merged

refactor: Reduce code bloat by using lambdas. #1484

merged 3 commits into from
Dec 5, 2023

Conversation

tom-andersen
Copy link
Contributor

@tom-andersen tom-andersen commented Nov 22, 2023 •
edited
Loading

There is no functional change, just fewer objects wrapping functions.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: firestore Issues related to the googleapis/java-firestore API. labels Nov 22, 2023
@tom-andersen tom-andersen force-pushed the tomandersen/refactorToUseLambda branch from 0a40239 to c638354 Compare November 22, 2023 15:55
@tom-andersen tom-andersen changed the title Reduce code bloat by using lambdas. refactor: Reduce code bloat by using lambdas. Nov 22, 2023
@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@tom-andersen tom-andersen requested a review from wu-hui November 22, 2023 16:02
@tom-andersen tom-andersen marked this pull request as ready for review November 22, 2023 20:43
@tom-andersen tom-andersen requested a review from a team as a code owner November 22, 2023 20:43
@wu-hui wu-hui assigned tom-andersen and unassigned wu-hui Dec 4, 2023
@tom-andersen tom-andersen added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 4, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 4, 2023
@tom-andersen tom-andersen added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Dec 5, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 5, 2023
@tom-andersen tom-andersen added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 5, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 5, 2023
@tom-andersen tom-andersen added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 5, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 5, 2023
@tom-andersen tom-andersen requested a review from a team as a code owner December 5, 2023 21:57
@gcf-merge-on-green gcf-merge-on-green bot merged commit 7856130 into main Dec 5, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the tomandersen/refactorToUseLambda branch December 5, 2023 22:20
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@tom-andersen tom-andersen

Labels
api: firestore Issues related to the googleapis/java-firestore API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tom-andersen @wu-hui @yoshi-kokoro