test: adding tests for DML upsert features.

[arpan14]

• Tests are currently failing since feature is not in production. Merge once it releases.

[shreyaprg]

We can add 2 more tests as below. They cover cases like:

• Insert or ignore ignores existing rows.
• Insert or update inserts (not updates) in case of new rows.

@test
public void testInsertOrUpdateOnNewRow() {
if (dialect.dialect == Dialect.GOOGLE_STANDARD_SQL) {
executeUpdate(DML_COUNT_WITH_UPSERT, insertOrUpdateDml());
} else {
executeUpdate(DML_COUNT_WITH_UPSERT, insertOrUpdateDmlPostgresql());
}
assertThat(
getClient(dialect.dialect)
.singleUse(TimestampBound.strong())
.readRow("T", Key.of(String.format("%d-boo1", id)), Collections.singletonList("V"))
.getLong(0))
.isEqualTo(10);
assertThat(
getClient(dialect.dialect)
.singleUse(TimestampBound.strong())
.readRow("T", Key.of(String.format("%d-boo5", id)), Collections.singletonList("V"))
.getLong(0))
.isEqualTo(50);
// Delete the rows
executeUpdate(DML_COUNT_WITH_UPSERT, deleteDml());
assertThat(
getClient(dialect.dialect)
.singleUse(TimestampBound.strong())
.readRow("T", Key.of(String.format("%d-boo1", id)), Collections.singletonList("V")))
.isNull();
}

@test
public void testInsertOrIgnoreDmlOnExistingRow() {
// First insert few rows.
executeUpdate(DML_COUNT, insertDml());
assertThat(
getClient(dialect.dialect)
.singleUse(TimestampBound.strong())
.readRow("T", Key.of(String.format("%d-boo1", id)), Collections.singletonList("V"))
.getLong(0))
.isEqualTo(1);

// Existing rows are ignored, only 1 new row is inserted.
if (dialect.dialect == Dialect.GOOGLE_STANDARD_SQL) {
  executeUpdate(1, insertOrIgnoreDml());
} else {
  executeUpdate(1, insertOrIgnoreDmlPostgresql());
}
assertThat(
        getClient(dialect.dialect)
            .singleUse(TimestampBound.strong())
            .readRow("T", Key.of(String.format("%d-boo1", id)), Collections.singletonList("V"))
            .getLong(0))
    .isEqualTo(1);
assertThat(
        getClient(dialect.dialect)
            .singleUse(TimestampBound.strong())
            .readRow("T", Key.of(String.format("%d-boo5", id)), Collections.singletonList("V"))
            .getLong(0))
    .isEqualTo(5);
// Delete the rows
executeUpdate(DML_COUNT_WITH_UPSERT, deleteDml());
assertThat(
        getClient(dialect.dialect)
            .singleUse(TimestampBound.strong())
            .readRow("T", Key.of(String.format("%d-boo1", id)), Collections.singletonList("V")))
    .isNull();
}

[shreyaprg]

Can you pls add ORDER BY v to each subquery as below:
SELECT .. FROM T ORDER BY v

There should be no change change to the result

[shreyaprg]

What is the error due to ORDER BY ?

[shreyaprg]

Can we 2 more cases for duplicate rows:

@Test
  public void testInsertOrIgnoreDuplicateRows() {
    long expectedRowCount = 2;

    // Only unique keys are inserted. Duplicate keys are ignored.
    if (dialect.dialect == Dialect.GOOGLE_STANDARD_SQL) {
      executeUpdate(
          expectedRowCount,
          "INSERT OR IGNORE INTO T (k, v) VALUES ('1-boo1', 1), ('2-boo2', 2), ('1-boo1', 1)");
    } else {
      executeUpdate(
          expectedRowCount,
          "INSERT INTO T (k, v) VALUES ('1-boo1', 1), ('2-boo2', 2), , ('1-boo1', 1) "
              + "ON CONFLICT(k) DO NOTHING");
    }
    assertThat(
            getClient(dialect.dialect)
                .singleUse(TimestampBound.strong())
                .readRow("T", Key.of("1-boo1"), Collections.singletonList("V"))
                .getLong(0))
        .isEqualTo(1);
    // Delete the rows
    executeUpdate(expectedRowCount, deleteDml());
    assertThat(
            getClient(dialect.dialect)
                .singleUse(TimestampBound.strong())
                .readRow("T", Key.of(String.format("%d-boo1", id)), Collections.singletonList("V")))
        .isNull();
  }

  @Test
  public void testInsertOrUpdateDuplicateRows() {
    try {
      if (dialect.dialect == Dialect.GOOGLE_STANDARD_SQL) {
        executeUpdate(
            0, "INSERT OR UPDATE INTO T (k, v) VALUES ('1-boo1', 1), ('2-boo2', 2), ('1-boo1', 1)");
      } else {
        executeUpdate(
            0,
            "INSERT INTO T (k, v) VALUES ('1-boo1', 1), ('2-boo2', 2), , ('1-boo1', 1) "
                + "ON CONFLICT(k) DO UPDATE SET k = expected.k, v = expected.v");
      }
    } catch (SpannerException e) {
      assertThat(e.getErrorCode()).isEqualTo(ErrorCode.INVALID_ARGUMENT);
      assertThat(e.getMessage()).contains("Cannot affect a row second time for key('1-boo1')");
    }

    // No rows to delete as insert was unsuccessful.
    executeUpdate(0, deleteDml());
    assertThat(
            getClient(dialect.dialect)
                .singleUse(TimestampBound.strong())
                .readRow("T", Key.of(String.format("%d-boo1", id)), Collections.singletonList("V")))
        .isNull();
  }

[shreyaprg]

I see a syntax error in this line because of an extra comma: INSERT INTO T (k, v) VALUES ('1-boo1', 1), ('2-boo2', 2), **, (**'1-boo1', 1)
Pls remove the extra comma
INSERT INTO T (k, v) VALUES ('1-boo1', 1), ('2-boo2', 2), ('1-boo1', 1)

[shreyaprg]

I see a syntax error in this line because of an extra comma: INSERT INTO T (k, v) VALUES ('1-boo1', 1), ('2-boo2', 2), , ('1-boo1', 1)
Pls remove the extra comma.
INSERT INTO T (k, v) VALUES ('1-boo1', 1), ('2-boo2', 2), ('1-boo1', 1)