ci(spanner): improve performance of samples tests #3558
Conversation
product-auto-label
bot
added
size: s
samples/snippets/src/test/java/com/example/spanner/SpannerSampleIT.java
Outdated
Show resolved
Hide resolved
sakthivelmanii
force-pushed
the
optimize_sample_test_performance
branch
3 times, most recently
from
4426b9d to
63189a3
Compare
sakthivelmanii
force-pushed
the
optimize_sample_test_performance
branch
from
63189a3 to
2782d6b
Compare
| <forkCount>10</forkCount> | ||
| <reuseForks>false</reuseForks> |
There was a problem hiding this comment.
I don't think this does anything at the moment, as there are no integration tests defined in this project. Are we planning on adding tests here?
There was a problem hiding this comment.
It is. Currently we are runnings tests three times in all three modules.
| <forkCount>10</forkCount> | ||
| <reuseForks>false</reuseForks> |
There was a problem hiding this comment.
Same as for install-without-bom: There are no tests in this project at the moment, so I don't think this does anything
There was a problem hiding this comment.
It is. Currently we are runnings tests three times in all three modules.
| <excludes> | ||
| <exclude>**/SpannerSampleIT.java</exclude> | ||
| </excludes> |
There was a problem hiding this comment.
I understand that this one is slow, but do we really want to skip it all-together? And/or will we have some other nightly job that overrides this configuration and does include this test?
There was a problem hiding this comment.
I am introducing a new job to run this test alone in parallel so that it can be completed in an hour.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.