build: update gapic-generator-typescript to v4.4.1 (#1232)

* build: update gapic-generator-typescript to v4.4.1 PiperOrigin-RevId: 604765466 Source-Link: googleapis/googleapis@40203ca Source-Link: googleapis/googleapis-gen@07b7f3d Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDdiN2YzZGFkOGFhMTkxMmQ0YWNkY2ZkNjM2NWJiNDIzNmU0YjU0YiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: danieljbruce <[email protected]>
googleapis · Feb 9, 2024 · 74f1e28 · 74f1e28
1 parent cc8256b
commit 74f1e28
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 44 deletions.
diff --git a/src/v1/datastore_admin_client.ts b/src/v1/datastore_admin_client.ts
@@ -418,7 +418,7 @@ export class DatastoreAdminClient {
 
   /**
    * The DNS address for this API service.
-   * @deprecated
+   * @deprecated Use the apiEndpoint method of the client instance.
    * @returns {string} The DNS address for this service.
    */
   static get servicePath() {
@@ -435,9 +435,8 @@ export class DatastoreAdminClient {
   }
 
   /**
-   * The DNS address for this API service - same as servicePath,
-   * exists for compatibility reasons.
-   * @deprecated
+   * The DNS address for this API service - same as servicePath.
+   * @deprecated Use the apiEndpoint method of the client instance.
    * @returns {string} The DNS address for this service.
    */
   static get apiEndpoint() {
@@ -457,14 +456,6 @@ export class DatastoreAdminClient {
    * The DNS address for this API service.
    * @returns {string} The DNS address for this service.
    */
-  get servicePath() {
-    return this._servicePath;
-  }
-
-  /**
-   * The DNS address for this API service - same as servicePath().
-   * @returns {string} The DNS address for this service.
-   */
   get apiEndpoint() {
     return this._servicePath;
   }

diff --git a/src/v1/datastore_client.ts b/src/v1/datastore_client.ts
@@ -318,7 +318,7 @@ export class DatastoreClient {
 
   /**
    * The DNS address for this API service.
-   * @deprecated
+   * @deprecated Use the apiEndpoint method of the client instance.
    * @returns {string} The DNS address for this service.
    */
   static get servicePath() {
@@ -335,9 +335,8 @@ export class DatastoreClient {
   }
 
   /**
-   * The DNS address for this API service - same as servicePath,
-   * exists for compatibility reasons.
-   * @deprecated
+   * The DNS address for this API service - same as servicePath.
+   * @deprecated Use the apiEndpoint method of the client instance.
    * @returns {string} The DNS address for this service.
    */
   static get apiEndpoint() {
@@ -357,14 +356,6 @@ export class DatastoreClient {
    * The DNS address for this API service.
    * @returns {string} The DNS address for this service.
    */
-  get servicePath() {
-    return this._servicePath;
-  }
-
-  /**
-   * The DNS address for this API service - same as servicePath().
-   * @returns {string} The DNS address for this service.
-   */
   get apiEndpoint() {
     return this._servicePath;
   }

diff --git a/test/gapic_datastore_admin_v1.ts b/test/gapic_datastore_admin_v1.ts
@@ -161,12 +161,6 @@ function stubAsyncIterationCall<ResponseType>(
 
 describe('v1.DatastoreAdminClient', () => {
   describe('Common methods', () => {
-    it('has servicePath', () => {
-      const client = new datastoreadminModule.v1.DatastoreAdminClient();
-      const servicePath = client.servicePath;
-      assert.strictEqual(servicePath, 'datastore.googleapis.com');
-    });
-
     it('has apiEndpoint', () => {
       const client = new datastoreadminModule.v1.DatastoreAdminClient();
       const apiEndpoint = client.apiEndpoint;
@@ -201,19 +195,19 @@ describe('v1.DatastoreAdminClient', () => {
         stub.restore();
       });
     }
-    it('sets servicePath according to universe domain camelCase', () => {
+    it('sets apiEndpoint according to universe domain camelCase', () => {
       const client = new datastoreadminModule.v1.DatastoreAdminClient({
         universeDomain: 'example.com',
       });
-      const servicePath = client.servicePath;
+      const servicePath = client.apiEndpoint;
       assert.strictEqual(servicePath, 'datastore.example.com');
     });
 
-    it('sets servicePath according to universe domain snakeCase', () => {
+    it('sets apiEndpoint according to universe domain snakeCase', () => {
       const client = new datastoreadminModule.v1.DatastoreAdminClient({
         universe_domain: 'example.com',
       });
-      const servicePath = client.servicePath;
+      const servicePath = client.apiEndpoint;
       assert.strictEqual(servicePath, 'datastore.example.com');
     });
     it('does not allow setting both universeDomain and universe_domain', () => {

diff --git a/test/gapic_datastore_v1.ts b/test/gapic_datastore_v1.ts
@@ -89,12 +89,6 @@ function stubAsyncIterationCall<ResponseType>(
 
 describe('v1.DatastoreClient', () => {
   describe('Common methods', () => {
-    it('has servicePath', () => {
-      const client = new datastoreModule.v1.DatastoreClient();
-      const servicePath = client.servicePath;
-      assert.strictEqual(servicePath, 'datastore.googleapis.com');
-    });
-
     it('has apiEndpoint', () => {
       const client = new datastoreModule.v1.DatastoreClient();
       const apiEndpoint = client.apiEndpoint;
@@ -127,19 +121,19 @@ describe('v1.DatastoreClient', () => {
         stub.restore();
       });
     }
-    it('sets servicePath according to universe domain camelCase', () => {
+    it('sets apiEndpoint according to universe domain camelCase', () => {
       const client = new datastoreModule.v1.DatastoreClient({
         universeDomain: 'example.com',
       });
-      const servicePath = client.servicePath;
+      const servicePath = client.apiEndpoint;
       assert.strictEqual(servicePath, 'datastore.example.com');
     });
 
-    it('sets servicePath according to universe domain snakeCase', () => {
+    it('sets apiEndpoint according to universe domain snakeCase', () => {
       const client = new datastoreModule.v1.DatastoreClient({
         universe_domain: 'example.com',
       });
-      const servicePath = client.servicePath;
+      const servicePath = client.apiEndpoint;
       assert.strictEqual(servicePath, 'datastore.example.com');
     });
     it('does not allow setting both universeDomain and universe_domain', () => {