-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Attempt, Operation and GFE Metrics #1302
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per offline discussion waiting for unit test to mock RPC failure and validate attempt_count>1
@lszinv Build is failing
|
66f7a30
to
2dd3a0e
Compare
|
Investigating the 3.7 test failure. |
Ignore the last commit. Will be pushing a new one to fix the test without disabling it. |
2789dc0
to
c07edca
Compare
Apologies, forgot to run the mockserver tests with the last change. I've fixed the test failures. |
Implementation of the MetricTracer and SpannerMetricFactory, a specific instance of the MetricFactory that populates the factory with metadata specific to the Python Spanner Client.
The Implemented metrics: