Fixes step06 according to latest specs: sdpParams in RTCIceCandidate constructor and use promises #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…callback to fix TypeError thrown as per latest spec
… deprecated. Fixes sending first offer null description.
|
@samdutton Here are the changes I mentioned yesterday, thanks for looking into it! |
samdutton
approved these changes
Nov 4, 2020
|
Thanks Maria! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lack of sdpParams in the RTCIceCandidate constructor was throwing a newly created TypeError as per the latest spec draft and .
Moreover, the usage of callbacks in createOffer was causing a race condition that sometimes led to sending a null offer that caused an error on the other peer.