Delete code pertaining to incremental compilation #1183
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
--incremental
to--emit-ir
; delete all code pertaining to incremental operation, simplify the IR Source trait as a result. Net reduction of ~2k loc, simpler execution path, and less work done for a clean compile.For context, the incremental code was written prior to understanding just how dynamic the graph of tasks can be. We default it to off and it's not clear its completely reliable. If we find we want incremental one day we can start fresh; until then it's much simpler to just not do all the associated bookkeeping.
Apologies for the huge diff, it's almost all just deleting bookkeeping.
My intuition is this will lead to further simplifications.
We're doing less work so it shoudl be faster, but is it? - timed on M1 MacBook it appears it is:
JMM if happy.