Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip xml strings for ttx tables #1210

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Strip xml strings for ttx tables #1210

merged 1 commit into from
Jan 23, 2025

Conversation

rsheeter
Copy link
Contributor

python resources/scripts/ttx_diff.py 'https://github.com/docrepair-fonts/lugrasimo-fonts#sources/Lugrasimo-Regular.designspace' --compare gftools --config ~/.fontc_crater_cache/docrepair-fonts/lugrasimo-fonts/sources/config.yaml reports gasp 88.9%. If we diff the table ttx it seems to differ only in trailing newline:

# These tables look the same ... but ttx_diff reports them different
$ diff -u build/gftools/fontc.gasp.ttx build/gftools/fontmake.gasp.ttx
--- build/gftools/fontc.gasp.ttx	2025-01-22 22:54:39
+++ build/gftools/fontmake.gasp.ttx	2025-01-22 22:54:39
@@ -2,4 +2,3 @@
     <gaspRange rangeMaxPPEM="65535" rangeGaspBehavior="15"/>
   </gasp>
 
-  
\ No newline at end of file

# ttx reports the same length and checksum for the gasp produced by both compilers.

Strip the table xml to avoid such issues. The ttx_diff cmd above now reports gasp identical.

@rsheeter rsheeter added this to the fontc 1.0 milestone Jan 23, 2025
@anthrotype anthrotype added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit 5905081 Jan 23, 2025
10 checks passed
@anthrotype anthrotype deleted the strip branch January 23, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants