Merge pull request #867 from justvanrossum/issue865

Take discrete axes into account when checking for feature compatibility
googlefonts · Sep 2, 2024 · 12b68f0 · 12b68f0
2 parents 8ec3ef3 + de46064
commit 12b68f0
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/Lib/ufo2ft/_compilers/baseCompiler.py b/Lib/ufo2ft/_compilers/baseCompiler.py
@@ -326,8 +326,8 @@ def _compileNeededSources(self, designSpaceDoc):
 
         # If the feature files are compatible between the sources, we can save
         # time by building a variable feature file right at the end.
-        can_optimize_features = self.variableFeatures and _featuresCompatible(
-            designSpaceDoc
+        can_optimize_features = self.variableFeatures and all(
+            _featuresCompatible(doc) for doc in interpolableSubDocs
         )
         if can_optimize_features:
             self.logger.info("Features are compatible across masters; building later")