Log merging of kerning lookups

googlefonts · Jan 22, 2024 · 327e760 · 327e760
1 parent 6091072
commit 327e760
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/Lib/ufo2ft/featureWriters/kernFeatureWriter.py b/Lib/ufo2ft/featureWriters/kernFeatureWriter.py
@@ -851,7 +851,12 @@ def splitKerning(pairs, glyphScripts):
 
     kerningPerScript = mergeScripts(kerningPerScript)
 
-    for pairs in kerningPerScript.values():
+    for scripts, pairs in kerningPerScript.items():
+        if len(scripts) > 1:
+            LOGGER.info(
+                "Merging kerning lookups from the following scripts: %s",
+                ", ".join(scripts),
+            )
         pairs.sort()
 
     return kerningPerScript

diff --git a/tests/featureWriters/kernFeatureWriter_test.py b/tests/featureWriters/kernFeatureWriter_test.py
@@ -1535,10 +1535,10 @@ def test_kern_split_and_drop(FontClass, caplog):
         """
     )
 
-    msgs = sorted(msg[-31:] for msg in caplog.messages)
-    assert msgs == [
-        "with mixed direction (LTR, RTL)",
-        "with mixed direction (RTL, LTR)",
+    assert caplog.messages == [
+        "Skipping kerning pair <('a', 'a-orya', 'alpha') ('a-cy', 'alef-ar', 'period') 20> with mixed direction (LTR, RTL)",
+        "Skipping kerning pair <('a-cy', 'alef-ar', 'period') ('a', 'a-orya', 'alpha') 20> with mixed direction (RTL, LTR)",
+        "Merging kerning lookups from the following scripts: Cyrl, Grek, Latn, Orya",
     ]