[markFeatureWriter] Drop “ambiguously connected” info message #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a very noisy message, I get it like a thousand time when generating fonts. It also provides n much value, the glyphs are not “ambiguously connected” since our lookup order is deterministic and font developer engineer can control how lookups are ordered to have specific anchor take precedence over general ones by carefully naming the anchors. The alleged ambiguity does not influence the feature writer, it is producing the feature code the same way whether there is “ambiguity” or not. It rather affects how layout engines might apply the lookups, but why ufo2ft is concerning itself about that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very noisy message, I get it like a thousand time when generating fonts.
It also provides n much value, the glyphs are not “ambiguously connected” since our lookup order is deterministic and font developer engineer can control how lookups are ordered to have specific anchor take precedence over general ones by carefully naming the anchors.
The alleged ambiguity does not influence the feature writer, it is producing the feature code the same way whether there is “ambiguity” or not. It rather affects how layout engines might apply the lookups, but why ufo2ft is concerning itself about that?