Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix publish command #1450

Merged
merged 1 commit into from
Jan 21, 2025
Merged

chore: fix publish command #1450

merged 1 commit into from
Jan 21, 2025

Conversation

kikoso
Copy link
Collaborator

@kikoso kikoso commented Jan 21, 2025

The following PR fixes the publish command.

We had before this code in the main build gradle file, which was not being read on the Convention Plugin, which works on a different scope:

 artifactId = if (project.name == "library") {
                        "android-maps-utils"
                    } else {
                        null
                    }

One could say: how do we do it on the android-maps-utils? We name the modules as they should be named.

This should fix the generation of the artifact to have the proper artifactId. Checked locally with ./gradlew clean publishToMavenLocal

<?xml version="1.0" encoding="UTF-8"?>
<metadata>
  <groupId>com.google.maps.android</groupId>
  <artifactId>android-maps-utils</artifactId>
  <versioning>
    <latest>3.10.0</latest>
    <release>3.10.0</release>
    <versions>
      <version>3.10.0</version>
    </versions>
    <lastUpdated>20250121165121</lastUpdated>
  </versioning>
</metadata>

@googlemaps-bot
Copy link
Contributor

Code Coverage

Overall Project 34.43% 🍏

There is no coverage information present for the Files changed

@dkhawk dkhawk merged commit a7464a7 into main Jan 21, 2025
11 checks passed
@dkhawk dkhawk deleted the chore/fix_publish branch January 21, 2025 17:24
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 3.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants