-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix #412 #622 iOS resolver reference when iOS module not installed #714
base: master
Are you sure you want to change the base?
chore: fix #412 #622 iOS resolver reference when iOS module not installed #714
Conversation
…alled - updated export_unity_package_config.json and split the ExternalDependencyManager/Editor/*/Google.IOSResolver.* into its own definition, adding defineConstraints UNITY_EDITOR and UNITY_IOS
added defineConstraints to AssetConfiguration in export_unity_package.py added unit tests for defineConstraints in export_unity_package_test.py
This looks good, I'll try and get it reviewed :) |
Thanks for sending this, and diving into the export_unity_package script! At a first glance it seems good, but I'll want to spend some time testing it with different install configurations to make sure it doesn't cause any issues, which might take a little bit of time. But I'll try to get to it when I can! |
@a-maurice feel free to push any changes or remake this PR as needed :) |
export_unity_package_config.json
and separatedGoogle.IOSResolver.*
into its ownPluginImporter
section, addingdefineConstraints
key withUNITY_EDITOR
andUNITY_IOS
elements.export_unity_package_config.json
with standard json lint, 2 spacesdefineConstraints
toAssetConfiguration
inexport_unity_package.py
defineConstraints
inexport_unity_package_test.py
Fixes
Invalid when platform is not set to IOS or module not installed
Valid when platform is set to IOS
CC @a-maurice, @chkuang-g