Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add generic util function SliceHas #103

Merged
merged 3 commits into from
Jun 30, 2023
Merged

feat: add generic util function SliceHas #103

merged 3 commits into from
Jun 30, 2023

Conversation

XiaoK29
Copy link
Contributor

@XiaoK29 XiaoK29 commented Jun 29, 2023

No description provided.

@inhere
Copy link
Member

inhere commented Jun 30, 2023

👍 PR 很棒.

有几个问题：

  • 不能直接删除之前的 StringsHas ..., 会导致依赖这个库的项目升级包后报错
  • 可以新建一个泛型方法 Has 或者 ListHas SliceHas, InHas 有点奇怪
  • 泛型类型 可以使用 T comdef.ScalarType 替代 T int | int64 | string

@XiaoK29 XiaoK29 closed this Jun 30, 2023
@XiaoK29 XiaoK29 reopened this Jun 30, 2023
@XiaoK29
Copy link
Contributor Author

XiaoK29 commented Jun 30, 2023

👍 PR 很棒.

有几个问题：

  • 不能直接删除之前的 StringsHas ..., 会导致依赖这个库的项目升级包后报错
  • 可以新建一个泛型方法 Has 或者 ListHas SliceHas, InHas 有点奇怪
  • 泛型类型 可以使用 T comdef.ScalarType 替代 T int | int64 | string

已修改

@inhere inhere merged commit b439a24 into gookit:master Jun 30, 2023
6 of 18 checks passed
@inhere inhere added the enhancement New feature or request label Jun 30, 2023
@inhere inhere self-assigned this Jun 30, 2023
@inhere inhere changed the title Merge InStrings StringsHas Int64sHas IntsHas into InHas method feat: add generic util function SliceHas Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@inhere inhere

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XiaoK29 @inhere