-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[terraform]: allow to override service type #229
[terraform]: allow to override service type #229
Conversation
3225a14
to
397edf3
Compare
397edf3
to
ccd1c51
Compare
cc @nikParasyr |
@pierreprinetti @mandre @EmilienM kindly ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we even have a Terraform directory in utils? What is its purpose?
I have nothing against merging this, but I think we should have a migration plan for moving this code to the Terraform provider, if it's needed there
initially this was in the openstack terraform project, but this code is used in other terraform related projects that use non-vanilla openstack services. at some point we decided to move it into the gophercloud/utils to reduce the dependency tree. |
Do you think that having all Gophercloud functions accept ServiceClient as an interface (as proposed here) would solve this use-case? |
In theory yes, but the code base should contain some extra logic. Anyway, I don't think that terraform helper code will be rewritten after introducing the client interface. |
Indeed, that's fair. I'll keep my spring-cleaning instincts under control for the time being |
Resolves #228