Add CLI flag to retry HTTP requests #256
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to implementation details in certain hosting setups, there can be a delay between creating the temporary cachetool file and it being accessible via HTTP. To address this, both FileGetContents and SymfonyHTTP clients are extended to retry HTTP requests on failure. By default, that new configuration option is set to
3
, which should cover most cases. However, its value can also be adjusted via CLI (--web-retry
) or config file (webRetry
).The test setup is extended to cover both successful and failed retries. In the test setup, the availability delay of the php server is used to cover the mentioned test cases.
Resolves #209