Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid array usage to store disappearing transitions on beachsection removal #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fjwong
Copy link

@fjwong fjwong commented Jan 23, 2017

When a beachsection is removed, the original implementation creates an array and stores all "disappearing transitions" in it, so that the starting points of their edges can be updated.

This PR changes the removeBeachsection method so that endpoints are set when cycling through the disappearing transitions the first time, avoiding the creation of this new array, and reducing the amount of time spent on garbage collection because of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant