fix(#739): Remove else statement on route mismatch #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a path with specific query params does not match we should return a ErrMethodMismatch instead of ErrNotFound
1 task
|
I've reviewed and I'm happy with the code and tests to match. What needs to be considered now is if this is technically a breaking api change or not as folks utilising the library may expect the former error. @AlexVulaj would love your input on this. |
|
Actually I got confused - this PR (thanks to #748) is now obsolete. Thank you heaps for the contribution @marcelom97. If you feel that this was in error, please open up another issue to discuss. |
marcelom97
deleted the
fix/#739-MethodNotAllowedHandler-does-not-work-for-subrouter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
When a path with specific query params does not match we should return a ErrMethodMismatch instead of ErrNotFound
Related Tickets & Documents
Added/updated tests?
have not been included
Run verifications and test
make verifyis passingmake testis passing