Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the installation command #753

Closed
wants to merge 1 commit into from
Closed

Update the installation command #753

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,10 @@ The name mux stands for "HTTP request multiplexer". Like the standard `http.Serv
## Install

With a [correctly configured](https://golang.org/doc/install#testing) Go toolchain:

Replace "latest" with specific version
```sh
go get -u github.com/gorilla/mux
go install github.com/gorilla/mux@latest
Copy link

@jackgris jackgris Mar 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, maybe the command should be go get -u github.com/gorilla/mux@latest ???

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed - I'm in favor of staying with go get over go install here.

Copy link

@ghost ghost May 27, 2024 •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GauravRajwada The go install command is not appropriate here. The command fails with the error package github.com/gorilla/mux is not a main package.

The documentation is correct as is. @AlexVulaj this PR should be rejected.


```

## Examples
Expand Down
Loading