Merge pull request #70 from goshippo/master

Releasing v3.2.0 with tax id support
goshippo · Apr 23, 2021 · d60823e · d60823e
2 parents f0c1c0c + d87af6c
commit d60823e
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 4 deletions.
diff --git a/Shippo/CustomsDeclaration.cs b/Shippo/CustomsDeclaration.cs
@@ -27,6 +27,19 @@ public class ExporterIdentification : ShippoId
     {
         [JsonProperty(PropertyName = "eori_number")]
         public object EoriNumber { get; set; }
+
+        [JsonProperty(PropertyName = "tax_id")]
+        public TaxId TaxId { get; set; }
+    }
+
+    [JsonObject(MemberSerialization.OptIn)]
+    public class TaxId : ShippoId
+    {
+        [JsonProperty(PropertyName = "number")]
+        public object Number { get; set; }
+
+        [JsonProperty(PropertyName = "type")]
+        public object Type { get; set; }
     }
 
     [JsonObject(MemberSerialization.OptIn)]

diff --git a/Shippo/Shippo.csproj b/Shippo/Shippo.csproj
@@ -2,14 +2,14 @@
 
   <PropertyGroup>
     <TargetFrameworks>net45;net40</TargetFrameworks>
-    <Version>3.1.1</Version>
+    <Version>3.2.0</Version>
     <Title>Shippo client library</Title>
     <Description>.NET library which integrates with Shippo Multi Carrier Shipping API. This library provides access to Shippo (goshippo.com) API capabilities. Including label generation, rating, tracking and more.</Description>
     <Summary>Shippo Shipping API client Library (USPS, FedEx, UPS, and more)</Summary>
     <PackageProjectUrl>https://github.com/goshippo/shippo-csharp-client/</PackageProjectUrl>
     <RepositoryUrl>https://github.com/goshippo/shippo-csharp-client/</RepositoryUrl>
     <PackageTags>USPS Fedex UPS API Shippo</PackageTags>
-    <PackageReleaseNotes>Adding EORI support</PackageReleaseNotes>
+    <PackageReleaseNotes>Adding support for tax IDs such as VAT and EIN for customs declarations</PackageReleaseNotes>
     <RepositoryType>Github</RepositoryType>
     <GeneratePackageOnBuild>false</GeneratePackageOnBuild>
   </PropertyGroup>

diff --git a/ShippoTesting/CustomsDeclarationTest.cs b/ShippoTesting/CustomsDeclarationTest.cs
@@ -42,7 +42,10 @@ public void TestValidCreate()
             Assert.AreEqual(invoicedChargesParameters["other_fees"], testObject.InvoicedCharges.OtherFees);
             Assert.AreEqual(invoicedChargesParameters["currency"], testObject.InvoicedCharges.Currency);
 
-            var exporterIdentificationParameters = (Dictionary<String, String>)parameters["exporter_identification"];
+            var exporterIdentificationParameters = (Dictionary<String, Object>)parameters["exporter_identification"];
+            var taxIdParameters = (Dictionary<String, String>) exporterIdentificationParameters["tax_id"];
+            Assert.AreEqual(taxIdParameters["number"], testObject.ExporterIdentification.TaxId.Number);
+            Assert.AreEqual(taxIdParameters["type"], testObject.ExporterIdentification.TaxId.Type);
             Assert.AreEqual(exporterIdentificationParameters["eori_number"], testObject.ExporterIdentification.EoriNumber);
         }
 
@@ -114,8 +117,14 @@ public static Hashtable getDefaultParameters()
             };
             parameters.Add("invoiced_charges", invoicedCharges);
 
-            var exporterIdentification = new Dictionary<String, String>(){
+            var taxId = new Dictionary<String, String>()
+            {
+                {"number", "123456789"},
+                {"type", "EIN" }
+            };
+            var exporterIdentification = new Dictionary<String, Object>(){
                 {"eori_number", "PL12345678912345"},
+                {"tax_id", taxId}
             };
             parameters.Add("exporter_identification", exporterIdentification);